Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-10676

WelcomePluginsRootResource doesn't contain any JAX-RS annotated methods

    Details

    • Type: Bug Report
    • Status: Closed
    • Priority: L3 - Default
    • Resolution: Fixed
    • Affects Version/s: 7.12.0-alpha1
    • Fix Version/s: 7.12.0, 7.12.0-alpha3
    • Component/s: welcome
    • Labels:

      Description

      The resource WelcomePluginsRootResource does not provide any JAX-RS annotated methods. This causes deployment to fail for some containers, e.g. TomEE providing CXF as JAX-RS implementation. CXF checks resources for JAX-RS spec compliance and throws an error if a class annotated with @Path does not provide any annotated methods.

      I think the issue here is that WelcomePluginsRootResource is extending AbstractWelcomePluginResource, but it should extend AbstractWelcomePluginRootResource (note the "Root").
      At least all other application do it like this, see CockpitPluginsRootResource for example.

        Activity

        Hide
        miklas.boskamp Miklas Boskamp added a comment -

        Hi Erik Müller,

        thanks for raising this bug report. Your proposal sounds good to me. I can't tell why the welcome plugin resource differs from all our other webapps.
        If you like to contribute a fix feel free to raise a pull request.

        Cheers,
        Miklas

        Show
        miklas.boskamp Miklas Boskamp added a comment - Hi Erik Müller , thanks for raising this bug report. Your proposal sounds good to me. I can't tell why the welcome plugin resource differs from all our other webapps. If you like to contribute a fix feel free to raise a pull request. Cheers, Miklas
        Hide
        em Erik Müller added a comment - - edited

        Hi @miklas.boskamp,
        I would like to push my feature branch (to create a pull request) but I seem to miss permissions
        ERROR: Permission to camunda/camunda-bpm-webapp.git denied to asterikx.

        Show
        em Erik Müller added a comment - - edited Hi @miklas.boskamp, I would like to push my feature branch (to create a pull request) but I seem to miss permissions ERROR: Permission to camunda/camunda-bpm-webapp.git denied to asterikx.
        Hide
        miklas.boskamp Miklas Boskamp added a comment -

        Hi Erik Müller,

        You can not push to the camunda/camunda-bpm-webapp repository directly. You need to fork it so you have your own repo to work on in GitHub. From there you can open a pull request that merges the feature branch into our repository.

        Cheers,
        Miklas

        Show
        miklas.boskamp Miklas Boskamp added a comment - Hi Erik Müller , You can not push to the camunda/camunda-bpm-webapp repository directly. You need to fork it so you have your own repo to work on in GitHub. From there you can open a pull request that merges the feature branch into our repository. Cheers, Miklas
        Hide
        miklas.boskamp Miklas Boskamp added a comment -

        Hi Erik Müller,

        I merged your Pull Request into the master branch. Thanks for contributing.

        Cheers,
        Miklas

        Show
        miklas.boskamp Miklas Boskamp added a comment - Hi Erik Müller , I merged your Pull Request into the master branch. Thanks for contributing. Cheers, Miklas

          People

          • Assignee:
            Unassigned
            Reporter:
            em Erik Müller
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development