Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-2799

Upgrade json-path version used by spin to 2.x

    Details

      Issue Links

        Activity

        Hide
        gimbel Robert Gimbel added a comment - - edited

        Is that an easypick?

        Show
        gimbel Robert Gimbel added a comment - - edited Is that an easypick?
        Hide
        thorben.lindhauer Thorben Lindhauer added a comment -

        Yes but you have to know which hacks you can remove from the codebase. So it is not just changing the dependency version and running the test suite.

        Show
        thorben.lindhauer Thorben Lindhauer added a comment - Yes but you have to know which hacks you can remove from the codebase. So it is not just changing the dependency version and running the test suite.
        Hide
        thorben.lindhauer Thorben Lindhauer added a comment -

        I am not sure whether making this upgrade now is a good idea.
        I updated the version and the good thing is that we can remove our boilerplate code.
        The bad thing is that four test cases fail that were previously running. These test cases cover cases in which invalid json-path queries are made, like "$....."
        In 0.9.1, json-path was able to wrap the exceptions of malformed input into its own exceptions, with 1.1.0, you get from a user's perspective quite useless exceptions like StringIndexOutOfBoundsException.
        I'll discuss this with the other devs tomorrow.

        Show
        thorben.lindhauer Thorben Lindhauer added a comment - I am not sure whether making this upgrade now is a good idea. I updated the version and the good thing is that we can remove our boilerplate code. The bad thing is that four test cases fail that were previously running. These test cases cover cases in which invalid json-path queries are made, like "$....." In 0.9.1, json-path was able to wrap the exceptions of malformed input into its own exceptions, with 1.1.0, you get from a user's perspective quite useless exceptions like StringIndexOutOfBoundsException. I'll discuss this with the other devs tomorrow.
        Hide
        thorben.lindhauer Thorben Lindhauer added a comment - - edited

        We excluded the dependency org.ow2.asm:asm:5.0.4 from Spin via https://github.com/camunda/camunda-spin/commit/3b727fed2fc550c0aab40f617780d5e007ed1b50. This dependency is used by many projects and us shipping it can cause issues on application servers that do not handle versioning so well (https://hq2.camunda.com/jenkins/ci/job/7.8-EE-engine-IT-XA-websphere-80-postgresql-91 was failing in our environment where Websphere has artifacts with asm 3.2.0 that would prevent Arquillian from deploying test artifacts). According to the json-path project maintainers, this exclusion should be ok, see https://github.com/json-path/JsonPath/pull/315 and https://github.com/json-path/JsonPath/issues/224. However, they are not really clear about it (and it's not clear why they don't exclude the dependency themselves).

        Show
        thorben.lindhauer Thorben Lindhauer added a comment - - edited We excluded the dependency org.ow2.asm:asm:5.0.4 from Spin via https://github.com/camunda/camunda-spin/commit/3b727fed2fc550c0aab40f617780d5e007ed1b50 . This dependency is used by many projects and us shipping it can cause issues on application servers that do not handle versioning so well ( https://hq2.camunda.com/jenkins/ci/job/7.8-EE-engine-IT-XA-websphere-80-postgresql-91 was failing in our environment where Websphere has artifacts with asm 3.2.0 that would prevent Arquillian from deploying test artifacts). According to the json-path project maintainers, this exclusion should be ok, see https://github.com/json-path/JsonPath/pull/315 and https://github.com/json-path/JsonPath/issues/224 . However, they are not really clear about it (and it's not clear why they don't exclude the dependency themselves).

          People

          • Assignee:
            thorben.lindhauer Thorben Lindhauer
            Reporter:
            thorben.lindhauer Thorben Lindhauer
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development