Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-6274

Database scripts contain invalid characters and comments

    Details

      Description

      Problem:
      The database create and upgrade scripts (maybe delete too) contain invalid characters which causes them to fail when they are executed using a database vendor REPL like mysql. DB2 and Oracle scripts also have some problems accordingly to some manual smoke tests.

      AT:

      • Clean all database scripts on all branches from invalid formatted comments, invalid characters etc.
      • All scripts are tested by running them against the database using the database vendor own REPL tool manually.
      • Test-DB-Upgrade runs successfully with option 'keepFormat' set to true for the sql-maven-plugin

        Issue Links

          Activity

          lipphardt Christian Lipphardt created issue -
          Hide
          sebastian.menski Sebastian Menski added a comment -

          Does this ticket replace CAM-6246?

          Show
          sebastian.menski Sebastian Menski added a comment - Does this ticket replace CAM-6246 ?
          lipphardt Christian Lipphardt made changes -
          Field Original Value New Value
          Link This issue is duplicated by CAM-6246 [ CAM-6246 ]
          lipphardt Christian Lipphardt made changes -
          Component/s continuous integration [ 12058 ]
          meyer Daniel Meyer made changes -
          Assignee Christopher Zell [ christopher.zell ]
          meyer Daniel Meyer made changes -
          Fix Version/s 7.2.x [ 14198 ]
          christopher.zell Christopher Zell made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          lipphardt Christian Lipphardt made changes -
          Fix Version/s 7.2.x [ 14198 ]
          christopher.zell Christopher Zell made changes -
          Fix Version/s 7.2.10 [ 14594 ]
          Fix Version/s 7.3.8 [ 14596 ]
          Fix Version/s 7.4.9 [ 14603 ]
          Fix Version/s 7.4.x [ 14196 ]
          Fix Version/s 7.3.x [ 14197 ]
          Fix Version/s 7.2.x [ 14198 ]
          christopher.zell Christopher Zell made changes -
          Link This issue depends on CAM-6334 [ CAM-6334 ]
          christopher.zell Christopher Zell made changes -
          Fix Version/s 7.5.3 [ 14604 ]
          Fix Version/s 7.5.x [ 14200 ]
          christopher.zell Christopher Zell made changes -
          Link This issue depends on CAM-6338 [ CAM-6338 ]
          christopher.zell Christopher Zell made changes -
          Link This issue depends on CAM-6342 [ CAM-6342 ]
          christopher.zell Christopher Zell made changes -
          Link This issue depends on CAM-6341 [ CAM-6341 ]
          christopher.zell Christopher Zell made changes -
          Link This issue depends on CAM-6339 [ CAM-6339 ]
          christopher.zell Christopher Zell made changes -
          Link This issue depends on CAM-6340 [ CAM-6340 ]
          christopher.zell Christopher Zell made changes -
          Link This issue depends on CAM-6343 [ CAM-6343 ]
          christopher.zell Christopher Zell made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          Hide
          gimbel Robert Gimbel added a comment -

          This ticket has somehow the wrong versions. 7.5.3 is released but this ticket it open. Does not fit.

          Show
          gimbel Robert Gimbel added a comment - This ticket has somehow the wrong versions. 7.5.3 is released but this ticket it open. Does not fit.
          christopher.zell Christopher Zell made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Assignee Christopher Zell [ christopher.zell ] Sebastian Menski [ sebastian.menski ]
          Resolution Fixed [ 1 ]
          Hide
          sebastian.menski Sebastian Menski added a comment -

          Christopher Zell what is the reason for this commit? https://github.com/camunda/camunda-bpm-platform/commit/1eaca673f795c78165b56f8fa2ad30b63d91e198

          • a property is set which is not used?
          • why was the oracle driver added to the pom?
          Show
          sebastian.menski Sebastian Menski added a comment - Christopher Zell what is the reason for this commit? https://github.com/camunda/camunda-bpm-platform/commit/1eaca673f795c78165b56f8fa2ad30b63d91e198 a property is set which is not used? why was the oracle driver added to the pom?
          Hide
          sebastian.menski Sebastian Menski added a comment -

          Robert Gimbel to answer your question: the changes where part of the 7.5.3 release, only the review was not done.

          Show
          sebastian.menski Sebastian Menski added a comment - Robert Gimbel to answer your question: the changes where part of the 7.5.3 release, only the review was not done.
          sebastian.menski Sebastian Menski made changes -
          Status Resolved [ 5 ] In Progress [ 3 ]
          sebastian.menski Sebastian Menski made changes -
          Assignee Sebastian Menski [ sebastian.menski ] Christopher Zell [ christopher.zell ]
          christopher.zell Christopher Zell made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Assignee Christopher Zell [ christopher.zell ] Sebastian Menski [ sebastian.menski ]
          sebastian.menski Sebastian Menski made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          gimbel Robert Gimbel made changes -
          Fix Version/s 7.6.0-alpha3 [ 14609 ]
          michael.schoettes Michael Schoettes made changes -
          Fix Version/s 7.4.10 [ 14693 ]
          michael.schoettes Michael Schoettes made changes -
          Fix Version/s 7.4.9 [ 14603 ]
          meyer Daniel Meyer made changes -
          Component/s continuous integration [ 12058 ]
          Component/s maintenance [ 11750 ]
          thorben.lindhauer Thorben Lindhauer made changes -
          Workflow camunda BPM [ 38980 ] Backup_camunda BPM [ 61801 ]

            People

            • Assignee:
              sebastian.menski Sebastian Menski
              Reporter:
              lipphardt Christian Lipphardt
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development