Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-6362

wrong interpretation of manual activation rule

    Details

      Description

      We need to change the behaviour of the manual activation rule

      This issue is cause through a bug in the standard

        Issue Links

          Activity

          Hide
          askar.akhmerov Askar Akhmerov added a comment -

          pushed on master will do backporting now.

          Show
          askar.akhmerov Askar Akhmerov added a comment - pushed on master will do backporting now.
          Hide
          sebastian.menski Sebastian Menski added a comment -

          Askar Akhmerov can you look at the failing instance migration test. I'm not sure if they are related to this ticket but if please fix them.

          https://hq2.camunda.com/jenkins/ci/job/7.6-platform-UPGRADE-instance-migration/database=h2,jdk=jdk-6-latest/lastCompletedBuild/testReport/

          Show
          sebastian.menski Sebastian Menski added a comment - Askar Akhmerov can you look at the failing instance migration test. I'm not sure if they are related to this ticket but if please fix them. https://hq2.camunda.com/jenkins/ci/job/7.6-platform-UPGRADE-instance-migration/database=h2,jdk=jdk-6-latest/lastCompletedBuild/testReport/
          Hide
          menge Falko Menge added a comment -

          I just tried the nightly build of the engine at my current consulting customer and it behaves correctly for Task without Manual Activation Marker and Task with a Manual Activation condition expression. Thanks, for fixing that!

          However, Tasks that have a Manual Activation Marker but NO condition expression are automatically activated. Please, change this to follow the specification in OMG-12.

          Show
          menge Falko Menge added a comment - I just tried the nightly build of the engine at my current consulting customer and it behaves correctly for Task without Manual Activation Marker and Task with a Manual Activation condition expression. Thanks, for fixing that! However, Tasks that have a Manual Activation Marker but NO condition expression are automatically activated. Please, change this to follow the specification in OMG-12.
          Hide
          menge Falko Menge added a comment -

          Currently, one would be forced to always put

          ${true}
          

          as a condition expression to make the marker work.

          Show
          menge Falko Menge added a comment - Currently, one would be forced to always put ${ true } as a condition expression to make the marker work.
          Hide
          askar.akhmerov Askar Akhmerov added a comment - - edited

          Falko Menge, just to clarify, are we talking about empty conditions only, or also about the cases when condition is completely omitted?

                  <defaultControl>
                    <manualActivationRule>
                      <condition></condition>
                    </manualActivationRule>
                  </defaultControl>
          

          and

                  <defaultControl>
                    <manualActivationRule>
                    </manualActivationRule>
                  </defaultControl>
          

          the second one is a bit more ugly to implement, I would have to actually look at the DOM elements to identify if manual activation is undefined completely or just condition is omitted, as I see it right now.

          Show
          askar.akhmerov Askar Akhmerov added a comment - - edited Falko Menge , just to clarify, are we talking about empty conditions only, or also about the cases when condition is completely omitted? <defaultControl> <manualActivationRule> <condition></condition> </manualActivationRule> </defaultControl> and <defaultControl> <manualActivationRule> </manualActivationRule> </defaultControl> the second one is a bit more ugly to implement, I would have to actually look at the DOM elements to identify if manual activation is undefined completely or just condition is omitted, as I see it right now.
          Hide
          menge Falko Menge added a comment -

          Hi Askar,

          essentially, one should be able to add the Manual Activation marker in
          the Camunda Modeler and that should be all. Currently, the Modeler
          creates the following XML, when I do that:

                 <cmmn:planItem id="PlanItem_1" definitionRef="ProcessTask_1nqedwi">
                   <cmmn:itemControl id="PlanItemControl_1g652f2">
                     <cmmn:manualActivationRule id="ManualActivationRule_0wuwwz9" />
                   </cmmn:itemControl>
                 </cmmn:planItem>
          

          Since, we don't know how other modeling tools will serialize this, the
          engine should behave the same in both cases that you described.

          Cheers,
          Falko

          Show
          menge Falko Menge added a comment - Hi Askar, essentially, one should be able to add the Manual Activation marker in the Camunda Modeler and that should be all. Currently, the Modeler creates the following XML, when I do that: <cmmn:planItem id= "PlanItem_1" definitionRef= "ProcessTask_1nqedwi" > <cmmn:itemControl id= "PlanItemControl_1g652f2" > <cmmn:manualActivationRule id= "ManualActivationRule_0wuwwz9" /> </cmmn:itemControl> </cmmn:planItem> Since, we don't know how other modeling tools will serialize this, the engine should behave the same in both cases that you described. Cheers, Falko
          Hide
          menge Falko Menge added a comment -

          The second one is probably the more important one.

          Show
          menge Falko Menge added a comment - The second one is probably the more important one.
          Show
          sebastian.menski Sebastian Menski added a comment - 7.2 Assembly is broken: https://ci.camunda.com/jenkins/7.2/job/7.2-platform-ASSEMBLY/11/

            People

            • Assignee:
              roman.smirnov Smirnov Roman
              Reporter:
              gimbel Robert Gimbel
            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: