Details

      Description

      I noticed that the use of "ID" (or "Id") is not always consistent and this should be corrected and
      always use one of both (I create a poll in the forum to ask which version should be used https://forum.camunda.org/t/poll-how-do-you-like-your-identifiers/1149/1).

        Activity

        Hide
        valentin.vago Valentin Vago added a comment -

        It will be "ID" (according to the poll)

        Show
        valentin.vago Valentin Vago added a comment - It will be "ID" (according to the poll)
        Hide
        sebastian.stamm Sebastian Stamm added a comment -

        At some places there is still "Id" or "id" used:

        • admin user create
        • admin setup page
        • admin group create
        • admin user -> add to group modal
        • admin user groups listing
        • admin tenant create
        • admin list of tenants
        • admin user -> add to tenant modal
        • admin user tenants listing
        • admin group -> add to tenant modal
        • admin group tenant listing
        • admin authorizations listing "Resource Id"
        • admin valid license screen: 'Customer Id'
        • cockpit process instance migration failure: 'Failed to apply the Migration Plan to the Process Instance with id'
        • cockpit cancel process instances dialog: 'Process instance id'
        • cockpit selectActivity and selectActivityInstance directive, error message: 'No activity id query given in @cam-select-activity'
        • tasklist create/edit filter modal -> criteria: "Activity Instance Id In", "Execution Id"
        • takslist create/edit filter modal -> Input Placeholder Text
        • tasklist create task: "Tenant Id" (only for tenants)
        • tasklist add task to group modal hint: "You can add a group by typing a group id into ..."
        • tasklist Task locales file: "Case instance id" (can be used in history tab)
        • tasklist label INIT_EXTERNAL_FORM_FAILED: "Cannot initialize external form url: either task id or ..."

        Changes to the Tasklist translation files should also be added to the Tasklist translations community repo

        Show
        sebastian.stamm Sebastian Stamm added a comment - At some places there is still "Id" or "id" used: admin user create admin setup page admin group create admin user -> add to group modal admin user groups listing admin tenant create admin list of tenants admin user -> add to tenant modal admin user tenants listing admin group -> add to tenant modal admin group tenant listing admin authorizations listing "Resource Id" admin valid license screen: 'Customer Id' cockpit process instance migration failure: 'Failed to apply the Migration Plan to the Process Instance with id' cockpit cancel process instances dialog: 'Process instance id' cockpit selectActivity and selectActivityInstance directive, error message: 'No activity id query given in @cam-select-activity' tasklist create/edit filter modal -> criteria: "Activity Instance Id In", "Execution Id" takslist create/edit filter modal -> Input Placeholder Text tasklist create task: "Tenant Id" (only for tenants) tasklist add task to group modal hint: "You can add a group by typing a group id into ..." tasklist Task locales file: "Case instance id" (can be used in history tab) tasklist label INIT_EXTERNAL_FORM_FAILED: "Cannot initialize external form url: either task id or ..." Changes to the Tasklist translation files should also be added to the Tasklist translations community repo
        Hide
        valentin.vago Valentin Vago added a comment -

        It looks to me like there's an issue with the build...
        I think we have to look at that together, because most of what you listed as missing changes or the cockpit header (other issue) are actually just fine (on my machine ).

        Show
        valentin.vago Valentin Vago added a comment - It looks to me like there's an issue with the build... I think we have to look at that together, because most of what you listed as missing changes or the cockpit header (other issue) are actually just fine (on my machine ).
        Hide
        sebastian.stamm Sebastian Stamm added a comment -

        While most of the admin issues are fixed with the correct build parameters (my bad ^^"), misalignments in Cockpit and Tasklist remain and I was unable to find a commit fixing them:

        • admin tenant create (helptext)
        • admin valid license screen: 'Customer Id'
        • cockpit process instance migration failure: 'Failed to apply the Migration Plan to the Process Instance with id'
        • cockpit cancel process instances dialog: 'Process instance id'
        • cockpit selectActivity and selectActivityInstance directive, error message: 'No activity id query given in @cam-select-activity'
        • tasklist create/edit filter modal -> criteria: "Activity Instance Id In", "Execution Id"
        • tasklist create/edit filter modal -> permissions -> Input Placeholder Text
        • tasklist create task: "Tenant Id" (only for tenants)
        • tasklist add task to group modal hint: "You can add a group by typing a group id into ..."
        • tasklist Task locales file: "Case instance id" (can be used in history tab)
        • tasklist label INIT_EXTERNAL_FORM_FAILED: "Cannot initialize external form url: either task id or ..."
        Show
        sebastian.stamm Sebastian Stamm added a comment - While most of the admin issues are fixed with the correct build parameters (my bad ^^"), misalignments in Cockpit and Tasklist remain and I was unable to find a commit fixing them: admin tenant create (helptext) admin valid license screen: 'Customer Id' cockpit process instance migration failure: 'Failed to apply the Migration Plan to the Process Instance with id' cockpit cancel process instances dialog: 'Process instance id' cockpit selectActivity and selectActivityInstance directive, error message: 'No activity id query given in @cam-select-activity' tasklist create/edit filter modal -> criteria: "Activity Instance Id In", "Execution Id" tasklist create/edit filter modal -> permissions -> Input Placeholder Text tasklist create task: "Tenant Id" (only for tenants) tasklist add task to group modal hint: "You can add a group by typing a group id into ..." tasklist Task locales file: "Case instance id" (can be used in history tab) tasklist label INIT_EXTERNAL_FORM_FAILED: "Cannot initialize external form url: either task id or ..."
        Hide
        valentin.vago Valentin Vago added a comment -

        I think I got all the occurrences you mentioned.

        Show
        valentin.vago Valentin Vago added a comment - I think I got all the occurrences you mentioned.
        Hide
        sebastian.stamm Sebastian Stamm added a comment -

        Almost

        https://github.com/camunda/camunda-bpm-webapp/blob/master/ui/admin/client/scripts/pages/tenantCreate.html#L25

        Other than that I couldn't find any more. Could you also update the en.json tasklist translation file in the community repo with the latest changes?

        Show
        sebastian.stamm Sebastian Stamm added a comment - Almost https://github.com/camunda/camunda-bpm-webapp/blob/master/ui/admin/client/scripts/pages/tenantCreate.html#L25 Other than that I couldn't find any more. Could you also update the en.json tasklist translation file in the community repo with the latest changes?

          People

          • Assignee:
            michael.schoettes Michael Schoettes
            Reporter:
            valentin.vago Valentin Vago
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development