Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-6456

Sentry variableOnParts are evaluated on Variable Events

    Details

    • Type: Feature Request
    • Status: Closed
    • Priority: L3 - Default
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.6.0, 7.6.0-alpha3
    • Component/s: engine
    • Labels:
      None

      Description

      TODO:

      1. Register VariableOnPart listeners such that sentry with variableOnParts are evaluated when a variable undergoes a transition.
      2. Adjust AbstractVariableScope to trigger a call to the listening variableOnParts

        Issue Links

          Activity

          Hide
          meyer Daniel Meyer added a comment - - edited

          Feedback:

          • Folder "camunda-engine/src/test/resources/org/camunda/bpm/engine/test/cmmn/sentry/VariableOnPart" should not use capital letters
          • org.camunda.bpm.engine.impl.cmmn.execution.CmmnExecution.handleVariableTransition(String, String) => remove "Step X labels from comments"
          • affectedSentries should probably be a Set instead of a List?
          • org.camunda.bpm.engine.impl.cmmn.execution.CmmnExecution.hasVariableWithSameNameInParent(CmmnExecution, String) broken if variable exists but has value null. Needs to use getVariableLocalTyped()
          • Discussion: can we simplify handleVariableTransition() and checkAndFireNotAffectedSentries() in the following way?
            • Variable event occurs
            • Satisfy all matching Variable on parts
            • Then trigger evaluation of all if parts (if any) of all sentries for which all on parts are satisfied.
          • I think that Exit Criteria tests should go into separate file as well
          Show
          meyer Daniel Meyer added a comment - - edited Feedback: Folder "camunda-engine/src/test/resources/org/camunda/bpm/engine/test/cmmn/sentry/VariableOnPart" should not use capital letters org.camunda.bpm.engine.impl.cmmn.execution.CmmnExecution.handleVariableTransition(String, String) => remove "Step X labels from comments" affectedSentries should probably be a Set instead of a List? org.camunda.bpm.engine.impl.cmmn.execution.CmmnExecution.hasVariableWithSameNameInParent(CmmnExecution, String) broken if variable exists but has value null. Needs to use getVariableLocalTyped() Discussion: can we simplify handleVariableTransition() and checkAndFireNotAffectedSentries() in the following way? Variable event occurs Satisfy all matching Variable on parts Then trigger evaluation of all if parts (if any) of all sentries for which all on parts are satisfied. I think that Exit Criteria tests should go into separate file as well

            People

            • Assignee:
              meyer Daniel Meyer
              Reporter:
              deivarayan.azhagappan Deivarayan Azhagappan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development