Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-1211

I can reorder table columns via drag and drop

    Details

    • Type: Feature Request
    • Status: Done
    • Priority: L3 - Default
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0-alpha2, 2.1.0
    • Component/s: frontend
    • Labels:
      None

      Description

      AT:

      • In the report edit mode, I can re-arrange columns by grabbing a column by the header, moving it around and dropping it between two other columns
      • If the column is not dropped between two other columns, nothing happens
      • While grabbing a column, the column content is grayed out until the column is dropped
      • A representation of the column is following the mouse during the drag and drop operation
      • When hovering over a header, the cursor changes to indicate a possible grab interaction
      • Order of the columns is persisted when the report is saved and applies to report view mode, dashboards, shared views, and CSV export
      • When a column is hidden and the un-hidden, it retains its position

        Activity

        Hide
        johannes.heinemann Johannes Heinemann added a comment -

        Nice, that looks a lot better

        Show
        johannes.heinemann Johannes Heinemann added a comment - Nice, that looks a lot better
        Hide
        johannes.heinemann Johannes Heinemann added a comment -

        Review hints:

        • I like the code, especially in the processRawData.js. It is very expressive what is done in each row
        • processRawData.js/ColumnRearragement: the columnOrder is split up between meta and variables. Later in the code you label everything that is not related to variables 'processInstanceProps'. I think we should make that consistent and I would rather go for the 'processInstanceProps' than meta.
        • processRawData.js: the function getNestedColumnsForLastEntry() could be renamed to something like getNestedColumnsForVariables to make clear that this is related to the variables.
        • Report.js: the logic of if we want to show columns interactions does not belong here, since we have all kinds of reports that can be rendered here and they are not concerned with the column interactions. Think about using a addon mechanism that we already have in the dashboard.
        Show
        johannes.heinemann Johannes Heinemann added a comment - Review hints: I like the code, especially in the processRawData.js. It is very expressive what is done in each row processRawData.js/ColumnRearragement: the columnOrder is split up between meta and variables. Later in the code you label everything that is not related to variables 'processInstanceProps'. I think we should make that consistent and I would rather go for the 'processInstanceProps' than meta. processRawData.js: the function getNestedColumnsForLastEntry() could be renamed to something like getNestedColumnsForVariables to make clear that this is related to the variables. Report.js: the logic of if we want to show columns interactions does not belong here, since we have all kinds of reports that can be rendered here and they are not concerned with the column interactions. Think about using a addon mechanism that we already have in the dashboard.
        Hide
        johannes.heinemann Johannes Heinemann added a comment -

        Show
        johannes.heinemann Johannes Heinemann added a comment -
        Hide
        sebastian.stamm Sebastian Stamm added a comment -

        I would like to keep it separate as it is a new feature and not an improvement of an existing feature and it might involve subtickets on its own.

        Show
        sebastian.stamm Sebastian Stamm added a comment - I would like to keep it separate as it is a new feature and not an improvement of an existing feature and it might involve subtickets on its own.
        Hide
        johannes.heinemann Johannes Heinemann added a comment -

        Nice ticket description

        Do we want to add that as feature part for OPT-1170?

        Show
        johannes.heinemann Johannes Heinemann added a comment - Nice ticket description Do we want to add that as feature part for OPT-1170 ?

          People

          • Assignee:
            Unassigned
            Reporter:
            sebastian.stamm Sebastian Stamm
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: