Works really nice. Well done Sebastian
If I paste something in the input field of the external add report modal, then I can't confirm the modal with key press enter. Could also be done in another ticket.
Good point. I think this behavior is also desired for some other modals where we only have a single text input field. I created
OPT-1256 for it.
I paste random stuff in the external source input field, then I get the page itself shown instead of an error that the external source could not be loaded.
This is expected behavior. The random nonsense you pasted was probably interpreted as relative URL to the current location. When you provide an actual nonexistent URL, you will get the standard error display of the browser.
It is not clear for mean what the AT "when rendering an external report, we do not render a title or have any optimize specific click behavior" means, because I can still click and interact with the external resource. Even when I add Optimize content as external resource.
For normal reports we add a title that, when clicked, brings the user to the report view. This AT checks that we do not have a title for the external reports and also do not provide a way to e.g. open the external page in a new tab (apart from what may be provided by the browser). That the user is able to interact with the external source is expected.
For the code hints: I refactored the AddButton and DashboardReport components, so that the optimize report and external report logic is in different components.