Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-1253

Reduce Code Duplication in EngineImportMediators

    Details

    • Type: Task
    • Status: Done
    • Priority: L3 - Default
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 2.4.0
    • Component/s: backend
    • Labels:
      None

      Description

      AT:

      • reduced code duplication in engineImportMediators
      • ideally a unit test of the mediator behavior (it's a crucial part of the import and bugs in e.g. the paging behavior might go unnoticed as we usually test with datasets << max page size)

      Note:
      The EngineImportMediators in package org.camunda.optimize.service.engine.importing.service.mediator all look very similar. We should try to refactor those classes to reduce code duplication.

        Issue Links

          Activity

          Hide
          michael.wagner Michael Wagner added a comment -

          do you think the new unit tests are good like this, or should I test something different(ly)?
          as for the refactorings: I guess there would be more potential to refactor here,
          e.g. using a common itnerface/abstract class for the entityFetchers or restructuring the files (separating abstract/interfaces to impl)
          wdyt?

          Show
          michael.wagner Michael Wagner added a comment - do you think the new unit tests are good like this, or should I test something different(ly)? as for the refactorings: I guess there would be more potential to refactor here, e.g. using a common itnerface/abstract class for the entityFetchers or restructuring the files (separating abstract/interfaces to impl) wdyt?

            People

            • Assignee:
              Unassigned
              Reporter:
              sebastian.stamm Sebastian Stamm
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: