Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-1287

Flow Node Filter does not show diagram in branch analysis

    Details

    • Type: Bug Report
    • Status: Done
    • Priority: L3 - Default
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-alpha1, 2.2.0
    • Component/s: frontend
    • Labels:
      None

      Description

      Reproduce

      • Create a new Branch Analysis by clicking on the analysis tab
      • Select a process definition
      • Select Add Filter
      • Select the Flow Node Filter

      Problem

      • A Flow Node filter does not show the process definition model like it is done in the report builder

      Expected Behavior

      • The Flow Node Filter shows also in the branch analysis the process definition xml

        Activity

        Hide
        omran.abazeed Omran Abazeed added a comment -

        Can you please check and let me know.

        Thanks

        Show
        omran.abazeed Omran Abazeed added a comment - Can you please check and let me know. Thanks
        Hide
        sebastian.stamm Sebastian Stamm added a comment -

        Works great! I like that you added a test. Two minor remarks:

        • We should remove the console.log statement in the test
        • I think the name of the test can be a bit more accurate. We are not testing that the filter shows the diagram, we just test that we pass the property. Something like it('should pass the xml to the Filter component') is more fitting in my opinion
        Show
        sebastian.stamm Sebastian Stamm added a comment - Works great! I like that you added a test. Two minor remarks: We should remove the console.log statement in the test I think the name of the test can be a bit more accurate. We are not testing that the filter shows the diagram, we just test that we pass the property. Something like it('should pass the xml to the Filter component') is more fitting in my opinion
        Hide
        omran.abazeed Omran Abazeed added a comment -

        Yea you are right, I did the changes. Please have a look.

        Thanks

        Show
        omran.abazeed Omran Abazeed added a comment - Yea you are right, I did the changes. Please have a look. Thanks
        Hide
        sebastian.stamm Sebastian Stamm added a comment -

        Great work!

        Show
        sebastian.stamm Sebastian Stamm added a comment - Great work!

          People

          • Assignee:
            Unassigned
            Reporter:
            michael.schoettes Michael Schoettes
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: