Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-1287

Flow Node Filter does not show diagram in branch analysis

    Details

    • Type: Bug Report
    • Status: Done
    • Priority: L3 - Default
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-alpha1, 2.2.0
    • Component/s: frontend
    • Labels:
      None

      Description

      Reproduce

      • Create a new Branch Analysis by clicking on the analysis tab
      • Select a process definition
      • Select Add Filter
      • Select the Flow Node Filter

      Problem

      • A Flow Node filter does not show the process definition model like it is done in the report builder

      Expected Behavior

      • The Flow Node Filter shows also in the branch analysis the process definition xml

        Activity

        michael.schoettes Michael Schoettes created issue -
        johannes.heinemann Johannes Heinemann made changes -
        Field Original Value New Value
        Assignee Johannes Heinemann [ johannes.heinemann ] Omran Abazeed [ omran.abazeed ]
        johannes.heinemann Johannes Heinemann made changes -
        Labels next_release
        johannes.heinemann Johannes Heinemann made changes -
        Rank Ranked higher
        johannes.heinemann Johannes Heinemann made changes -
        Summary Flow Node Filter selectable in Branch Analysis Flow Node Filter does not show diagram in branch analysis
        johannes.heinemann Johannes Heinemann made changes -
        Description *Reproduce*
        - Create a new Branch Analysis
        - Select Add Filter
        - Select the Flow Node Filter

        *Problem*
        - A Flow Node filter is useless in the context of Branch Analysis

        *Expected Behavior*
        - The Flow Node Filter is not selectable
        *Reproduce*
        - Create a new Branch Analysis by clicking on the analysis tab
        - Select a process definition
        - Select Add Filter
        - Select the Flow Node Filter

        *Problem*
        - A Flow Node filter does not show the process definition model like it is done in the report builder

        *Expected Behavior*
        - The Flow Node Filter shows also in the branch analysis the process definition xml
        johannes.heinemann Johannes Heinemann made changes -
        Labels next_release current_release next_release
        johannes.heinemann Johannes Heinemann made changes -
        Labels current_release next_release current_release
        omran.abazeed Omran Abazeed made changes -
        Status Open [ 1 ] In Development [ 10312 ]
        Hide
        omran.abazeed Omran Abazeed added a comment -

        Can you please check and let me know.

        Thanks

        Show
        omran.abazeed Omran Abazeed added a comment - Can you please check and let me know. Thanks
        omran.abazeed Omran Abazeed made changes -
        Status In Development [ 10312 ] In Review [ 10212 ]
        Assignee Omran Abazeed [ omran.abazeed ] Sebastian Stamm [ sebastian.stamm ]
        Hide
        sebastian.stamm Sebastian Stamm added a comment -

        Works great! I like that you added a test. Two minor remarks:

        • We should remove the console.log statement in the test
        • I think the name of the test can be a bit more accurate. We are not testing that the filter shows the diagram, we just test that we pass the property. Something like it('should pass the xml to the Filter component') is more fitting in my opinion
        Show
        sebastian.stamm Sebastian Stamm added a comment - Works great! I like that you added a test. Two minor remarks: We should remove the console.log statement in the test I think the name of the test can be a bit more accurate. We are not testing that the filter shows the diagram, we just test that we pass the property. Something like it('should pass the xml to the Filter component') is more fitting in my opinion
        sebastian.stamm Sebastian Stamm made changes -
        Status In Review [ 10212 ] Ready to implement [ 10000 ]
        sebastian.stamm Sebastian Stamm made changes -
        Assignee Sebastian Stamm [ sebastian.stamm ] Omran Abazeed [ omran.abazeed ]
        omran.abazeed Omran Abazeed made changes -
        Status Ready to implement [ 10000 ] In Development [ 10312 ]
        Hide
        omran.abazeed Omran Abazeed added a comment -

        Yea you are right, I did the changes. Please have a look.

        Thanks

        Show
        omran.abazeed Omran Abazeed added a comment - Yea you are right, I did the changes. Please have a look. Thanks
        omran.abazeed Omran Abazeed made changes -
        Status In Development [ 10312 ] In Review [ 10212 ]
        Assignee Omran Abazeed [ omran.abazeed ] Sebastian Stamm [ sebastian.stamm ]
        Hide
        sebastian.stamm Sebastian Stamm added a comment -

        Great work!

        Show
        sebastian.stamm Sebastian Stamm added a comment - Great work!
        sebastian.stamm Sebastian Stamm made changes -
        Assignee Sebastian Stamm [ sebastian.stamm ]
        Status In Review [ 10212 ] Done [ 10010 ]
        Resolution Fixed [ 1 ]
        sebastian.stamm Sebastian Stamm made changes -
        Fix Version/s 2.2.0-alpha1 [ 15328 ]
        johannes.heinemann Johannes Heinemann made changes -
        Fix Version/s 2.2.0 [ 15338 ]
        johannes.heinemann Johannes Heinemann made changes -
        Labels current_release
        johannes.heinemann Johannes Heinemann made changes -
        Workflow Camunda Optimize - 2.0 [ 51538 ] Camunda Optimize - 2.4 [ 66026 ]
        johannes.heinemann Johannes Heinemann made changes -
        PM Priority -1
        johannes.heinemann Johannes Heinemann made changes -
        PM Priority -1

          People

          • Assignee:
            Unassigned
            Reporter:
            michael.schoettes Michael Schoettes
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: