Details

    • Type: Sub-task
    • Status: Done
    • Priority: L3 - Default
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-alpha1, 2.2.0
    • Component/s: frontend
    • Labels:
      None

      Description

      Currently, the Variable Filter tries to do too much at once. We should split it into separate components for the different variable value types:

      • String (which includes the typeahead functionality for the variable values)
      • Number (multiple values with four possible operations)
      • Boolean (no text input)

        Activity

        Hide
        johannes.heinemann Johannes Heinemann added a comment - - edited

        I really love this refactoring

        Review hints:

        • I think the ticket description is a bit wrong here: when you separated the components, the variable filter couldn't handle date variable and thus there was no component for dates. I think we should remove this entry from the description.
        • There is one minor styling glitch in the variable filter summary: there is no space between the variable name and the word 'is', e.g see NoSpaceBetweenVariableNameAndIs.png
        • I think we change this ticket into a subtask of OPT-1292, since this refactoring was done in order to achieve OPT-1292. But this can be a matter of taste.
        Show
        johannes.heinemann Johannes Heinemann added a comment - - edited I really love this refactoring Review hints: I think the ticket description is a bit wrong here: when you separated the components, the variable filter couldn't handle date variable and thus there was no component for dates. I think we should remove this entry from the description. There is one minor styling glitch in the variable filter summary: there is no space between the variable name and the word 'is', e.g see NoSpaceBetweenVariableNameAndIs.png I think we change this ticket into a subtask of OPT-1292 , since this refactoring was done in order to achieve OPT-1292 . But this can be a matter of taste.

          People

          • Assignee:
            Unassigned
            Reporter:
            sebastian.stamm Sebastian Stamm
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: