Details

    • Type: Task
    • Status: Done
    • Priority: L3 - Default
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-alpha2, 2.2.0
    • Component/s: frontend
    • Labels:
      None

      Description

      Based on Franz' feedback in OPT-1356.

      AT:

      • The input in the top right (typeahead) has a visible margin to the right. There is no width defined for the input, I suggest setting the width of the input to 100% in the context of its container.
      • the font-size in the menu is set to 1em which results in 16px, should be 14px.
      • the checkmark denoting a selected entry seems to hang too low in relation to the text labels, this might be ok when the font-size has been fixed.
      • I have added the svg files for the arrow icon (left, up, right, down) to the project, please use these.

        Activity

        Hide
        omran.abazeed Omran Abazeed added a comment -

        Everything looks good to me.
        Only one small thing: in submenu.js, in line 30, the Icon class name is 'open-submenu'
        Maybe it is better to use Submenu_arrow or Submenu_Icon

        Show
        omran.abazeed Omran Abazeed added a comment - Everything looks good to me. Only one small thing: in submenu.js, in line 30, the Icon class name is 'open-submenu' Maybe it is better to use Submenu_ arrow or Submenu _Icon
        Hide
        sebastian.stamm Sebastian Stamm added a comment -

        In the context of OPT-1377 I changed the classname of the Icon to rightIcon (before reading your review hint). Do you think that name is okay?

        Show
        sebastian.stamm Sebastian Stamm added a comment - In the context of OPT-1377 I changed the classname of the Icon to rightIcon (before reading your review hint). Do you think that name is okay?
        Hide
        omran.abazeed Omran Abazeed added a comment -

        Great. Yea, it is fine

        Show
        omran.abazeed Omran Abazeed added a comment - Great. Yea, it is fine

          People

          • Assignee:
            Unassigned
            Reporter:
            sebastian.stamm Sebastian Stamm
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: