Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-1520

Move all type name constants from configuration to ElasticsearchConstants class

    Details

    • Type: Task
    • Status: Done
    • Priority: L3 - Default
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 2.4.0, 2.4.0-alpha1
    • Component/s: backend
    • Labels:
      None

      Description

      AT:

      • Move all Elasticsearch type and index name constants from configuration to the ElasticsearchConstants class
      • the default config file service-config.yaml also doesn't contain those entries anymore
      • the default config file in the documentation should be adjusted as well
      • Also use reference those types from the integrations tests. E.g. in the ElasticsearchIntegrationRule we have getters to retrieve the types.
      • Remove type definition from the test property files, e.g. the integration-rules.properties file

      Context:
      In the past we used to define all constants in the ConfigurationService, in order to allow the users to adjust the names, if they want to. However, that's actually something users don't want to do and also changes like that are not tested and very prone to error. Therefore, let's hard code all Elasticsearch type and index names in Optimize.

        Issue Links

          Activity

          johannes.heinemann Johannes Heinemann created issue -
          johannes.heinemann Johannes Heinemann made changes -
          Field Original Value New Value
          Link This issue is related to OPT-1477 [ OPT-1477 ]
          johannes.heinemann Johannes Heinemann made changes -
          Description *AT:*
          * Move all type and index name constants from configuration to ElasticsearchConstants class

          *Context:*
          In the past we used to define all constants in the ConfigurationService, in order to allow the users to adjust the names, if they want to. However, that's actually something users don't want to do and also changes like that are not tested and very prone to error. Therefore, let's hard code all Elasticsearch type and index names in Optimize.
          *AT:*
          * Move all Elasticsearch type and index name constants from configuration to the ElasticsearchConstants class
          * the default config file {{service-config.yaml}} also doesn't contain those entries anymore
          * the default config file in the [documentation|https://github.com/camunda/camunda-docs-optimize/blob/master/content/technical-guide/configuration/service-config.yaml] should be adjusted as well

          *Context:*
          In the past we used to define all constants in the ConfigurationService, in order to allow the users to adjust the names, if they want to. However, that's actually something users don't want to do and also changes like that are not tested and very prone to error. Therefore, let's hard code all Elasticsearch type and index names in Optimize.
          johannes.heinemann Johannes Heinemann made changes -
          Labels current_release
          johannes.heinemann Johannes Heinemann made changes -
          Labels current_release next_release
          johannes.heinemann Johannes Heinemann made changes -
          Assignee Sebastian Bathke [ sebastian.bathke ]
          johannes.heinemann Johannes Heinemann made changes -
          Labels next_release current_release next_release
          johannes.heinemann Johannes Heinemann made changes -
          Labels current_release next_release current_release
          sebastian.bathke Sebastian Bathke made changes -
          Rank Ranked lower
          johannes.heinemann Johannes Heinemann made changes -
          Description *AT:*
          * Move all Elasticsearch type and index name constants from configuration to the ElasticsearchConstants class
          * the default config file {{service-config.yaml}} also doesn't contain those entries anymore
          * the default config file in the [documentation|https://github.com/camunda/camunda-docs-optimize/blob/master/content/technical-guide/configuration/service-config.yaml] should be adjusted as well

          *Context:*
          In the past we used to define all constants in the ConfigurationService, in order to allow the users to adjust the names, if they want to. However, that's actually something users don't want to do and also changes like that are not tested and very prone to error. Therefore, let's hard code all Elasticsearch type and index names in Optimize.
          *AT:*
          * Move all Elasticsearch type and index name constants from configuration to the ElasticsearchConstants class
          * the default config file {{service-config.yaml}} also doesn't contain those entries anymore
          * the default config file in the [documentation|https://github.com/camunda/camunda-docs-optimize/blob/master/content/technical-guide/configuration/service-config.yaml] should be adjusted as well
          * Also use reference those types from the integrations tests. E.g. in the ElasticsearchIntegrationRule we have getters to retrieve the types.
          * Remove type definition from the test property files, e.g. the {integration-rules.properties} file

          *Context:*
          In the past we used to define all constants in the ConfigurationService, in order to allow the users to adjust the names, if they want to. However, that's actually something users don't want to do and also changes like that are not tested and very prone to error. Therefore, let's hard code all Elasticsearch type and index names in Optimize.
          johannes.heinemann Johannes Heinemann made changes -
          Description *AT:*
          * Move all Elasticsearch type and index name constants from configuration to the ElasticsearchConstants class
          * the default config file {{service-config.yaml}} also doesn't contain those entries anymore
          * the default config file in the [documentation|https://github.com/camunda/camunda-docs-optimize/blob/master/content/technical-guide/configuration/service-config.yaml] should be adjusted as well
          * Also use reference those types from the integrations tests. E.g. in the ElasticsearchIntegrationRule we have getters to retrieve the types.
          * Remove type definition from the test property files, e.g. the {integration-rules.properties} file

          *Context:*
          In the past we used to define all constants in the ConfigurationService, in order to allow the users to adjust the names, if they want to. However, that's actually something users don't want to do and also changes like that are not tested and very prone to error. Therefore, let's hard code all Elasticsearch type and index names in Optimize.
          *AT:*
          * Move all Elasticsearch type and index name constants from configuration to the ElasticsearchConstants class
          * the default config file {{service-config.yaml}} also doesn't contain those entries anymore
          * the default config file in the [documentation|https://github.com/camunda/camunda-docs-optimize/blob/master/content/technical-guide/configuration/service-config.yaml] should be adjusted as well
          * Also use reference those types from the integrations tests. E.g. in the ElasticsearchIntegrationRule we have getters to retrieve the types.
          * Remove type definition from the test property files, e.g. the {{integration-rules.properties}} file

          *Context:*
          In the past we used to define all constants in the ConfigurationService, in order to allow the users to adjust the names, if they want to. However, that's actually something users don't want to do and also changes like that are not tested and very prone to error. Therefore, let's hard code all Elasticsearch type and index names in Optimize.
          sebastian.bathke Sebastian Bathke made changes -
          Labels current_release current_release next_release
          sebastian.bathke Sebastian Bathke made changes -
          Labels current_release next_release next_release
          sebastian.bathke Sebastian Bathke made changes -
          Labels next_release current_release next_release
          sebastian.bathke Sebastian Bathke made changes -
          Labels current_release next_release current_release
          sebastian.bathke Sebastian Bathke made changes -
          Labels current_release next_release
          johannes.heinemann Johannes Heinemann made changes -
          Assignee Sebastian Bathke [ sebastian.bathke ] Kyrylo Zakurdaiev [ kyrylo.zakurdaiev ]
          johannes.heinemann Johannes Heinemann made changes -
          Labels next_release current_release
          kyrylo.zakurdaiev Kyrylo Zakurdaiev made changes -
          Status Open [ 1 ] In Development [ 10312 ]
          kyrylo.zakurdaiev Kyrylo Zakurdaiev made changes -
          Labels current_release next_release
          kyrylo.zakurdaiev Kyrylo Zakurdaiev made changes -
          Status In Development [ 10312 ] Ready to implement [ 10000 ]
          kyrylo.zakurdaiev Kyrylo Zakurdaiev made changes -
          Status Ready to implement [ 10000 ] In Review [ 10212 ]
          Assignee Kyrylo Zakurdaiev [ kyrylo.zakurdaiev ] Sebastian Bathke [ sebastian.bathke ]
          kyrylo.zakurdaiev Kyrylo Zakurdaiev made changes -
          Labels current_release next_release next_release
          johannes.heinemann Johannes Heinemann made changes -
          Labels next_release current_release next_release
          johannes.heinemann Johannes Heinemann made changes -
          Labels current_release next_release current_release
          sebastian.bathke Sebastian Bathke made changes -
          Assignee Sebastian Bathke [ sebastian.bathke ]
          Status In Review [ 10212 ] Done [ 10010 ]
          Resolution Done [ 10000 ]
          johannes.heinemann Johannes Heinemann made changes -
          Remote Link This issue links to "Page (camunda confluence)" [ 12514 ]
          sebastian.bathke Sebastian Bathke made changes -
          Fix Version/s 2.4.0-alpha1 [ 15369 ]
          kyrylo.zakurdaiev Kyrylo Zakurdaiev made changes -
          Labels current_release
          johannes.heinemann Johannes Heinemann made changes -
          Workflow Camunda Optimize - 2.0 [ 53342 ] Camunda Optimize - 2.4 [ 66242 ]
          sebastian.bathke Sebastian Bathke made changes -
          Fix Version/s 2.4.0 [ 15365 ]
          johannes.heinemann Johannes Heinemann made changes -
          PM Priority -1
          johannes.heinemann Johannes Heinemann made changes -
          PM Priority -1

            People

            • Assignee:
              Unassigned
              Reporter:
              johannes.heinemann Johannes Heinemann
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: