Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-21

I get feedback when the logout went wrong

    Details

    • Type: Feature Request
    • Status: Done
    • Priority: L3 - Default
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-alpha1, 2.2.0
    • Component/s: frontend
    • Labels:
      None
    • PM Priority:
      -1

      Description

      When the user clicks logout, but the server does not respond with a success code, the logout might have failed and the session has not been cleared on the server. This should be made transparent to the user.

      AT:

      • If the user clicks logout and the response code is not success, the error message is displayed
      • Error code Unauthorized should not raise an error to the user. This might happen if the user is already logged out, e.g. by session timeout.

        Issue Links

          Activity

          Hide
          sebastian.stamm Sebastian Stamm added a comment -
          • We should use the withErrorHandling HOC
          • As per Acceptance Test, the error code Unauthorized should not raise an error to the user
          • We should maybe show the actual error text instead of assuming a general internal server error
          Show
          sebastian.stamm Sebastian Stamm added a comment - We should use the withErrorHandling HOC As per Acceptance Test, the error code Unauthorized should not raise an error to the user We should maybe show the actual error text instead of assuming a general internal server error
          Hide
          sebastian.stamm Sebastian Stamm added a comment -
          • I still think we should display the error message from the backend when showing the alert instead of just a static string. Since we cannot assume the structure of the response, I would print the statusText of the error object
          Show
          sebastian.stamm Sebastian Stamm added a comment - I still think we should display the error message from the backend when showing the alert instead of just a static string. Since we cannot assume the structure of the response, I would print the statusText of the error object
          Show
          sebastian.stamm Sebastian Stamm added a comment - Commit is https://github.com/camunda/camunda-optimize/commit/3eebdd7f5ecc4c4c063f949a3632e944f538c92a

            People

            • Assignee:
              Unassigned
              Reporter:
              sebastian.stamm Sebastian Stamm
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: