Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-21

I get feedback when the logout went wrong

    Details

    • Type: Feature Request
    • Status: Done
    • Priority: L3 - Default
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-alpha1, 2.2.0
    • Component/s: frontend
    • Labels:
      None
    • PM Priority:
      -1

      Description

      When the user clicks logout, but the server does not respond with a success code, the logout might have failed and the session has not been cleared on the server. This should be made transparent to the user.

      AT:

      • If the user clicks logout and the response code is not success, the error message is displayed
      • Error code Unauthorized should not raise an error to the user. This might happen if the user is already logged out, e.g. by session timeout.

        Issue Links

          Activity

          sebastian.stamm Sebastian Stamm created issue -
          sebastian.stamm Sebastian Stamm made changes -
          Field Original Value New Value
          Link This issue depends on CAM-7207 [ CAM-7207 ]
          sebastian.stamm Sebastian Stamm made changes -
          Link This issue is related to CAM-7312 [ CAM-7312 ]
          meyer Daniel Meyer made changes -
          Project camunda BPM [ 10230 ] Camunda Optimize [ 10730 ]
          Key CAM-7357 OPT-21
          Component/s optimize [ 13652 ]
          Fix Version/s 1.0.0 [ 14705 ]
          Fix Version/s 7.7.0 [ 14607 ]
          kerstin.hebel Kerstin Hebel made changes -
          Workflow camunda BPM [ 41583 ] Camunda Optimize [ 42113 ]
          mariusz.sielski Mariusz Sielski made changes -
          Component/s frontend [ 13654 ]
          askar.akhmerov Askar Akhmerov made changes -
          Fix Version/s 1.0.0 [ 14705 ]
          kerstin.hebel Kerstin Hebel made changes -
          Workflow Camunda Optimize [ 42113 ] Copy of Camunda Optimize [ 45641 ]
          askar.akhmerov Askar Akhmerov made changes -
          Workflow Copy of Camunda Optimize [ 45641 ] Camunda Optimize - 2.0 [ 46714 ]
          johannes.heinemann Johannes Heinemann made changes -
          Workflow Camunda Optimize - 2.0 [ 46714 ] New Camunda Optimize - 2.0 [ 48541 ]
          johannes.heinemann Johannes Heinemann made changes -
          Workflow New Camunda Optimize - 2.0 [ 48541 ] Camunda Optimize - 2.0 [ 49714 ]
          johannes.heinemann Johannes Heinemann made changes -
          Assignee Omran Abazeed [ omran.abazeed ]
          omran.abazeed Omran Abazeed made changes -
          Status Open [ 1 ] In Development [ 10312 ]
          omran.abazeed Omran Abazeed made changes -
          Status In Development [ 10312 ] In Review [ 10212 ]
          Assignee Omran Abazeed [ omran.abazeed ] Johannes Heinemann [ johannes.heinemann ]
          johannes.heinemann Johannes Heinemann made changes -
          Assignee Johannes Heinemann [ johannes.heinemann ] Sebastian Stamm [ sebastian.stamm ]
          Hide
          sebastian.stamm Sebastian Stamm added a comment -
          • We should use the withErrorHandling HOC
          • As per Acceptance Test, the error code Unauthorized should not raise an error to the user
          • We should maybe show the actual error text instead of assuming a general internal server error
          Show
          sebastian.stamm Sebastian Stamm added a comment - We should use the withErrorHandling HOC As per Acceptance Test, the error code Unauthorized should not raise an error to the user We should maybe show the actual error text instead of assuming a general internal server error
          sebastian.stamm Sebastian Stamm made changes -
          Status In Review [ 10212 ] Ready to implement [ 10000 ]
          sebastian.stamm Sebastian Stamm made changes -
          Assignee Sebastian Stamm [ sebastian.stamm ] Omran Abazeed [ omran.abazeed ]
          omran.abazeed Omran Abazeed made changes -
          Status Ready to implement [ 10000 ] In Development [ 10312 ]
          omran.abazeed Omran Abazeed made changes -
          Status In Development [ 10312 ] In Review [ 10212 ]
          Assignee Omran Abazeed [ omran.abazeed ] Sebastian Stamm [ sebastian.stamm ]
          Hide
          sebastian.stamm Sebastian Stamm added a comment -
          • I still think we should display the error message from the backend when showing the alert instead of just a static string. Since we cannot assume the structure of the response, I would print the statusText of the error object
          Show
          sebastian.stamm Sebastian Stamm added a comment - I still think we should display the error message from the backend when showing the alert instead of just a static string. Since we cannot assume the structure of the response, I would print the statusText of the error object
          sebastian.stamm Sebastian Stamm made changes -
          Status In Review [ 10212 ] Ready to implement [ 10000 ]
          sebastian.stamm Sebastian Stamm made changes -
          Assignee Sebastian Stamm [ sebastian.stamm ] Omran Abazeed [ omran.abazeed ]
          omran.abazeed Omran Abazeed made changes -
          Status Ready to implement [ 10000 ] In Development [ 10312 ]
          omran.abazeed Omran Abazeed made changes -
          Status In Development [ 10312 ] In Review [ 10212 ]
          Assignee Omran Abazeed [ omran.abazeed ] Sebastian Stamm [ sebastian.stamm ]
          Show
          sebastian.stamm Sebastian Stamm added a comment - Commit is https://github.com/camunda/camunda-optimize/commit/3eebdd7f5ecc4c4c063f949a3632e944f538c92a
          sebastian.stamm Sebastian Stamm made changes -
          Assignee Sebastian Stamm [ sebastian.stamm ]
          Status In Review [ 10212 ] Done [ 10010 ]
          Resolution Fixed [ 1 ]
          sebastian.stamm Sebastian Stamm made changes -
          Fix Version/s 2.2.0-alpha1 [ 15328 ]
          johannes.heinemann Johannes Heinemann made changes -
          Fix Version/s 2.2.0 [ 15338 ]
          johannes.heinemann Johannes Heinemann made changes -
          Labels current_release
          johannes.heinemann Johannes Heinemann made changes -
          Workflow Camunda Optimize - 2.0 [ 49714 ] Camunda Optimize - 2.4 [ 64881 ]
          johannes.heinemann Johannes Heinemann made changes -
          PM Priority -1

            People

            • Assignee:
              Unassigned
              Reporter:
              sebastian.stamm Sebastian Stamm
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: