Details

      Description

      AT:

      • if multiple tenants are available for a particular process/decision definition there is an additional tenant multi-select in the report builder
      • by default all available tenants are preselected

      API:
      API to obtain available definition keys by version and with available tenants to select from
      https://github.com/camunda/camunda-optimize/wiki/Process-Definition#get-process-definition-available-versions--tenants-grouped-by-key
      https://github.com/camunda/camunda-optimize/wiki/Decision-Definition#get-decision-definition-available-versions--tenants-grouped-by-key

      API to provide tenantIds to a report definition data.tenantIds:
      https://github.com/camunda/camunda-optimize/wiki/Reports#single-decision-report
      https://github.com/camunda/camunda-optimize/wiki/Reports#single-process-report

      API to provide tenantIds to branchAnalysis:
      https://github.com/camunda/camunda-optimize/wiki/Analysis#get-correlation-for-branch-analysis

        Issue Links

          Activity

          Show
          asia.malina Asia Malina added a comment - Zeplin link: https://app.zeplin.io/project/5b4f294ab0d5cf0c2c391d1d/dashboard?seid=5cd4271c70cbdf685034d099
          Hide
          johannes.heinemann Johannes Heinemann added a comment -

          The code looks shiny as always Sebastian

          Review hints:

          • you broke the e2e tests by removing a selector. Let's fix them

          Some remarks on the design that we should discuss with Asia next week:

          • deselecting all tenants+ 'not defined' is the same as selecting just 'not defined'
          • on Zeplin it still says 'None' instead of not defined
          • 'not defined' is actually not a tenant, but a special behavior for selecting all definitions where no tenant has been set. We should emphasize this.
          • when all is disabled in the tenant dropdown, then the title of the dropdown says 'Select...' and on Zeplin it says 'Multiple...'
          • we can have long tenant names, but the displayed title is very short. So it might be hard to see what have been selected. Maybe we should at least think about showing the title on hover

          I'll create an appointment to discuss this.

          Show
          johannes.heinemann Johannes Heinemann added a comment - The code looks shiny as always Sebastian Review hints: you broke the e2e tests by removing a selector. Let's fix them Some remarks on the design that we should discuss with Asia next week: deselecting all tenants+ 'not defined' is the same as selecting just 'not defined' on Zeplin it still says 'None' instead of not defined 'not defined' is actually not a tenant, but a special behavior for selecting all definitions where no tenant has been set. We should emphasize this. when all is disabled in the tenant dropdown, then the title of the dropdown says 'Select...' and on Zeplin it says 'Multiple...' we can have long tenant names, but the displayed title is very short. So it might be hard to see what have been selected. Maybe we should at least think about showing the title on hover I'll create an appointment to discuss this.
          Hide
          johannes.heinemann Johannes Heinemann added a comment -

          works like a charm

          Show
          johannes.heinemann Johannes Heinemann added a comment - works like a charm

            People

            • Assignee:
              Unassigned
              Reporter:
              sebastian.bathke Sebastian Bathke
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: