[CAM-5819] Style Searchs and Filters Created: 19/Apr/16  Updated: 25/Nov/16  Resolved: 27/Apr/16

Status: Closed
Project: camunda BPM
Component/s: cockpit, tasklist
Affects Version/s: None
Fix Version/s: 7.5.0, 7.5.0-alpha4

Type: Task Priority: L3 - Default
Reporter: Valentin Vago Assignee: Michael Schoettes
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0 minutes
Time Spent: Not Specified
Original Estimate: 0 minutes

Issue Links:
Related
is related to CAM-3375 Avoid offering choices when only 1 po... Closed
is related to CAM-5392 Update form fields styling Closed

 Description   
  • Add criteria button
  • "Remove" button should go right (on wide layouts like processes search)
  • "Pills" need to have some kind of outline


 Comments   
Comment by Sebastian Stamm [ 26/Apr/16 ]

I could not find search or filter icons.

I could not find a call of focusMainField [1]. Did I miss something or is this dead code?

Is there a reason this code [2] is not removed?

[1]: https://github.com/camunda/camunda-commons-ui/commit/838e8072111d0674e2e0f765d5a8cb6e3b78f8e1#diff-31490fde7ae8aa9dabec694e3ecfc91bR485
[2]: https://github.com/camunda/camunda-commons-ui/commit/838e8072111d0674e2e0f765d5a8cb6e3b78f8e1#diff-09527171f870492fd734d3651cb3f113R4

Comment by Valentin Vago [ 27/Apr/16 ]

You didn't miss anything (as usual ). My bad.
I removed the search and filter icons because they were not "helping" and the focusMainField was used on them.
So.. thanks, once again, for the sharp review!

Generated at Thu Jun 20 07:40:25 CEST 2019 using JIRA 6.4.6#64021-sha1:33e5b454af4594f54560ac233c30a6e00459507e.