I can filter by date variables (OPT-1292)

[OPT-1309] Refactor VariableFilter component Created: 03/Jul/18  Updated: 18/Apr/19  Resolved: 17/Jul/18

Status: Done
Project: Camunda Optimize
Component/s: frontend
Affects Version/s: None
Fix Version/s: 2.2.0-alpha1, 2.2.0

Type: Sub-task Priority: L3 - Default
Reporter: Sebastian Stamm Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File NoSpaceBetweenVariableNameAndIs.png    


Currently, the Variable Filter tries to do too much at once. We should split it into separate components for the different variable value types:

  • String (which includes the typeahead functionality for the variable values)
  • Number (multiple values with four possible operations)
  • Boolean (no text input)

Comment by Johannes Heinemann [ 16/Jul/18 ]

I really love this refactoring

Review hints:

  • I think the ticket description is a bit wrong here: when you separated the components, the variable filter couldn't handle date variable and thus there was no component for dates. I think we should remove this entry from the description.
  • There is one minor styling glitch in the variable filter summary: there is no space between the variable name and the word 'is', e.g see NoSpaceBetweenVariableNameAndIs.png
  • I think we change this ticket into a subtask of OPT-1292, since this refactoring was done in order to achieve OPT-1292. But this can be a matter of taste.
Generated at Sun Oct 20 05:06:03 CEST 2019 using JIRA 6.4.6#64021-sha1:33e5b454af4594f54560ac233c30a6e00459507e.