[OPT-21] I get feedback when the logout went wrong Created: 23/Jan/17  Updated: 18/Apr/19  Resolved: 19/Jul/18

Status: Done
Project: Camunda Optimize
Component/s: frontend
Affects Version/s: None
Fix Version/s: 2.2.0-alpha1, 2.2.0

Type: Feature Request Priority: L3 - Default
Reporter: Sebastian Stamm Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depedendency
depends on OPT-25 add notifications Done
Related
is related to OPT-39 integrate logout with backend Done
PM Priority: -1

 Description   

When the user clicks logout, but the server does not respond with a success code, the logout might have failed and the session has not been cleared on the server. This should be made transparent to the user.

AT:

  • If the user clicks logout and the response code is not success, the error message is displayed
  • Error code Unauthorized should not raise an error to the user. This might happen if the user is already logged out, e.g. by session timeout.


 Comments   
Comment by Sebastian Stamm [ 18/Jul/18 ]
  • We should use the withErrorHandling HOC
  • As per Acceptance Test, the error code Unauthorized should not raise an error to the user
  • We should maybe show the actual error text instead of assuming a general internal server error
Comment by Sebastian Stamm [ 18/Jul/18 ]
  • I still think we should display the error message from the backend when showing the alert instead of just a static string. Since we cannot assume the structure of the response, I would print the statusText of the error object
Comment by Sebastian Stamm [ 19/Jul/18 ]

Commit is https://github.com/camunda/camunda-optimize/commit/3eebdd7f5ecc4c4c063f949a3632e944f538c92a

Generated at Sun Jul 21 10:38:52 CEST 2019 using JIRA 6.4.6#64021-sha1:33e5b454af4594f54560ac233c30a6e00459507e.