Support for Multi-Tenancy (OPT-1800)

[OPT-2234] Tenant selection in Report Builder Created: 10/May/19  Updated: 28/Jun/19  Resolved: 07/Jun/19

Status: Done
Project: Camunda Optimize
Component/s: frontend
Affects Version/s: None
Fix Version/s: 2.5.0

Type: Sub-task Priority: L3 - Default
Reporter: Sebastian Bathke Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: current_release, product_design
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depedendency
depends on OPT-2204 Report Definition with tenant filter Done
is depended on by OPT-2249 Remove groupedByKey endpoints Done

 Description   

AT:

  • if multiple tenants are available for a particular process/decision definition there is an additional tenant multi-select in the report builder
  • by default all available tenants are preselected

API:
API to obtain available definition keys by version and with available tenants to select from
https://github.com/camunda/camunda-optimize/wiki/Process-Definition#get-process-definition-available-versions--tenants-grouped-by-key
https://github.com/camunda/camunda-optimize/wiki/Decision-Definition#get-decision-definition-available-versions--tenants-grouped-by-key

API to provide tenantIds to a report definition data.tenantIds:
https://github.com/camunda/camunda-optimize/wiki/Reports#single-decision-report
https://github.com/camunda/camunda-optimize/wiki/Reports#single-process-report

API to provide tenantIds to branchAnalysis:
https://github.com/camunda/camunda-optimize/wiki/Analysis#get-correlation-for-branch-analysis



 Comments   
Comment by Asia Malina [ 10/May/19 ]

Zeplin link:
https://app.zeplin.io/project/5b4f294ab0d5cf0c2c391d1d/dashboard?seid=5cd4271c70cbdf685034d099

Comment by Johannes Heinemann [ 27/May/19 ]

The code looks shiny as always Sebastian

Review hints:

  • you broke the e2e tests by removing a selector. Let's fix them

Some remarks on the design that we should discuss with Asia next week:

  • deselecting all tenants+ 'not defined' is the same as selecting just 'not defined'
  • on Zeplin it still says 'None' instead of not defined
  • 'not defined' is actually not a tenant, but a special behavior for selecting all definitions where no tenant has been set. We should emphasize this.
  • when all is disabled in the tenant dropdown, then the title of the dropdown says 'Select...' and on Zeplin it says 'Multiple...'
  • we can have long tenant names, but the displayed title is very short. So it might be hard to see what have been selected. Maybe we should at least think about showing the title on hover

I'll create an appointment to discuss this.

Comment by Johannes Heinemann [ 07/Jun/19 ]

works like a charm

Generated at Tue Sep 17 04:24:36 CEST 2019 using JIRA 6.4.6#64021-sha1:33e5b454af4594f54560ac233c30a6e00459507e.